Skip to content

V5#565

Merged
dotdoom merged 3 commits intomainfrom
v5
Mar 1, 2026
Merged

V5#565
dotdoom merged 3 commits intomainfrom
v5

Conversation

@dotdoom
Copy link
Member

@dotdoom dotdoom commented Mar 1, 2026

No description provided.

@dotdoom dotdoom self-assigned this Mar 1, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request prepares for the v5 release by focusing on significant development environment updates, dependency management improvements, and internal utility refinements. It includes a complete migration of the ESLint configuration to the modern flat config format, enhances Dependabot's update strategy with dependency grouping, and updates the action's documentation and core xcrun function for better output handling and stability.

Highlights

  • ESLint Configuration Migration: Migrated the ESLint setup from the legacy .eslintrc.json and .eslintignore files to the new flat configuration system using eslint.config.mjs, integrating TypeScript, Jest, and Prettier.
  • Dependabot Configuration Enhancements: Updated the Dependabot configuration to introduce grouped updates for GitHub Actions and npm development/production dependencies, and adjusted the update schedule to weekly for better management.
  • v5 Release Features: Added new entries to CHANGELOG.md for v5, including a fix for flaky boot issues with a retry parameter and improved printing of stdout/stderr even when commands fail.
  • Documentation and Dependency Updates: Updated README.md to reflect the v5 action version and modernized the build status badge. Numerous development dependencies in package.json were also upgraded.
  • Improved xcrun Output Handling: Modified the xcrun utility function to correctly handle stdout and stderr as Buffer types, ensuring proper string conversion for logging and return values.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a major version update (v5), featuring significant dependency upgrades, a migration to ESLint's new flat configuration format, and an improved Dependabot setup. A high-severity security concern has been identified regarding the underlying use of child_process.exec with string interpolation for executing system commands, which poses a command injection risk; transitioning to execFile or spawn is strongly recommended. Additionally, the PR includes fixes for logging command output on failure and addressing flaky simulator boots. My review also notes a minor typo in the changelog and suggests improving type consistency within the error handling logic in src/xcrun.ts.

@dotdoom dotdoom enabled auto-merge March 1, 2026 16:31
@dotdoom dotdoom requested review from ksheremet and removed request for ksheremet March 1, 2026 16:31
@dotdoom dotdoom merged commit e89aa8f into main Mar 1, 2026
3 checks passed
@dotdoom dotdoom deleted the v5 branch March 1, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants